Add aarch64 fdb build & Update lib features #1174
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vickunwu
force-pushed
the
main
branch
3 times, most recently
from
c806d7a to
c3e1825
Compare
Great, we can migrate to it as the default. Can this PR be merged?
If it is not related to FDB then please start a new discussion. Thanks! |
Yes, I think so. It's been successfully compiled. But I am not sure if it's still compatible with FDB 7.1.x. |
|
Please let me know once you're done with the changes and I'll merge. |
|
Sorry. The 2nd commit is supposed to address the image & binary signing issue. Should I open another PR or just change the title of this one? |
|
It's fine, we can use this same PR. |
vickunwu
force-pushed
the
main
branch
18 times, most recently
from
52ac7c0 to
291f8c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finishes building arm64 fdb-variant server as the FoundationDB latest stable release includes the libfdb_c_aarch64.so file.
I also noticed that foundationdb crate has a feature
fdb-7_3since0.9.0.Maybe we should consider deprecating thefdb-7_1feature some day.These 2 features seems conflicting each other when building. Since it's using
libfdb_c_$ARCH.soreleased in 7.3.x, I think it's better to keep the support offdb-7_3.There's also something I want to discuss regarding the last CI refactor.
But I'm not sure whether we should talk it